Skip to content

Remove Server Hostname from Capabilities (WebDav)#28539

Merged
PVince81 merged 1 commit into
masterfrom
remove_servername_from_capabilities
Aug 9, 2017
Merged

Remove Server Hostname from Capabilities (WebDav)#28539
PVince81 merged 1 commit into
masterfrom
remove_servername_from_capabilities

Conversation

@mmattel

@mmattel mmattel commented Jul 31, 2017

Copy link
Copy Markdown
Contributor

Description

See referenced merged PR
Many thanks to @individual-it
When capabilities are called, the servers hostname should not be included
@DeepDiver1975 I was just working on the referenced PR while you merged it 😄

Related Issue

Followup to #28513

Motivation and Context

Security

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975

Copy link
Copy Markdown
Member

@DeepDiver1975 I was just working on the referenced PR while you merged it 😄

funny - again - sorry

next time please set the label from 'to review' back to 'developing' - this will be a hint to not merge ;-)
THX

@mmattel

mmattel commented Jul 31, 2017

Copy link
Copy Markdown
Contributor Author

Will do,
it was a note from @individual-it regarding the parameters at another place which made me thinking about this. Now this one should be the last one for that topic 😄

@mmattel

mmattel commented Aug 2, 2017

Copy link
Copy Markdown
Contributor Author

@DeepDiver1975
might take a look and merge?

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 6485d21 into master Aug 9, 2017
@PVince81 PVince81 deleted the remove_servername_from_capabilities branch August 9, 2017 19:07
@PVince81

PVince81 commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

@mmattel if the original change was backported to stable10 please backport this one too

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants